Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error): highlight bind error location #863

Merged
merged 6 commits into from
Dec 25, 2024
Merged

feat(error): highlight bind error location #863

merged 6 commits into from
Dec 25, 2024

Conversation

wangrunji0408
Copy link
Member

@wangrunji0408 wangrunji0408 commented Dec 23, 2024

Sqlparser introduced span since v0.53. This PR utilizes span to improve error reporting.

> create table t(a int);
> select b from t;
bind error: invalid column "b"

LINE 1: select b from t;
               ^

Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
@wangrunji0408 wangrunji0408 added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit c41cd65 Dec 25, 2024
5 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/span branch December 25, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants