Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes all explicitness information in RISE #176

Merged
merged 7 commits into from
Jun 3, 2021
Merged

Conversation

umazalakain
Copy link
Contributor

Builds on top of #174

Copy link
Member

@Bastacyclop Bastacyclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

src/main/scala/rise/core/makeClosed.scala Outdated Show resolved Hide resolved
Base automatically changed from only-preserve to master May 31, 2021 08:32
Copy link
Member

@michel-steuwer michel-steuwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michel-steuwer
Copy link
Member

I merged master into this branch already: a95a9a7

Let's wait a bit to see if/when this trickles down here to the PR ...

@umazalakain umazalakain enabled auto-merge June 3, 2021 07:35
@umazalakain umazalakain disabled auto-merge June 3, 2021 07:35
@michel-steuwer
Copy link
Member

I have opened a ticket with GitHub support for them to investigate why the commits to this branch do not show up here.

@umazalakain
Copy link
Contributor Author

@michel-steuwer yes, something weird is going on. For now I tried to push to master directly, but it's a protected branch

@michel-steuwer michel-steuwer merged commit a95a9a7 into master Jun 3, 2021
@michel-steuwer michel-steuwer deleted the no-explicitness branch June 3, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants