-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insn cmd to interactive debug mode #1709
Add insn cmd to interactive debug mode #1709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a reasonable addition to me, but do you think it makes sense to enhance it by printing out the disassembled instruction after printing out its opcode? I guess it doesn't matter much since the main purpose is the until
aspect, not the printing aspect, so I'll leave it up to you.
It would be nice. I have a commit ready to add it but I'm unsure of the format for output. Right now it looks like the following: (spike) insn 0
0x0202859300000297 auipc t0, 0x0 If there is no preference on the format (i.e. |
Done. |
Yeah, that's fine. Can you squash these commits into one? |
Also note that CI is broken until #1710 is merged. |
Will do. |
f143a3f
to
c409f7b
Compare
c409f7b
to
e72fcaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR adds a new interactive debug mode cmd of
insn
with the same API as thepc
command to print out the instruction associated with the PC of a specific hart. This command can be used with theuntil*
commands to run a binary "until" the "insn" value is a specific value.