Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates 2.0.4 issue 93 #157

Open
wants to merge 7 commits into
base: updates-2.0.4
Choose a base branch
from

Conversation

IainCRobertson
Copy link
Collaborator

Updates to address Issue 93. Need confirmation from Paul Donahue (who raised that issue) that this addresses it

defined, indicated by the value 0.
|*qual_status*| 2| 00 (no_change): No change to filter qualification +
01 (ended_rep): Qualification ended, preceding *te_inst* sent explicitly to indicate last qualification
01 (ended_rep): Qualification ended, preceding *te_inst* sent explicitly to indicate final qualification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing where this text exists in the existing PDF, I notice that it doesn't properly show any of the 2-bit values before the parentheses. That should be fixed so people know what the encodings are.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a failure of the semi-automatic LaTeX to adoc conversion process that got missed at the time. I had fixed many of these, but your comment prompted me to do a thorough review and I found a few more, which I have now fixed and included in the PR.

payload.adoc Outdated Show resolved Hide resolved
payload.adoc Outdated Show resolved Hide resolved
IainCRobertson and others added 2 commits November 12, 2024 17:27
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: IainCRobertson <[email protected]>
Co-authored-by: Paul Donahue <[email protected]>
Signed-off-by: IainCRobertson <[email protected]>
@IainCRobertson IainCRobertson marked this pull request as ready for review November 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants