Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify page size 4KB. #94

Merged
merged 1 commit into from
Feb 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions specification/09-coveio_abi.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ The possible error codes returned in `sbiret.error` are shown below.
struct sbiret sbi_covh_add_tvm_interface_region(unsigned long tvm_id,
unsigned long device_if_id,
unsigned long base_addr,
unsigned long num_pages);
unsigned long region_len);
-----

Adds a device interface MMIO region into a TVM address space.
Expand All @@ -170,6 +170,10 @@ enable the created mappings until the TVM accepts the TDI in its TCB.

The possible error codes returned in `sbiret.error` are shown below.

`base_addr` value must be 4KB-aligned.

`region_len` value must be 4KB-aligned.

[#table_sbi_covh_add_tvm_interface_region]
.CoVE Host Add TVM Interface Region
[cols="2,3", width=90%, align="center", options="header"]
Expand All @@ -185,7 +189,7 @@ The possible error codes returned in `sbiret.error` are shown below.
struct sbiret sbi_covh_reclaim_tvm_interface_region(unsigned long tvm_id,
unsigned long device_if_id,
unsigned long base_addr,
unsigned long num_pages);
unsigned long region_len);
-----

Reclaims a device interface MMIO region previously added to a TVM address space.
Expand All @@ -199,6 +203,10 @@ unbinds the device interface from the TVM first.

The possible error codes returned in `sbiret.error` are shown below.

`base_addr` value must be 4KB-aligned.

`region_len` value must be 4KB-aligned.

[#table_sbi_covh_reclaim_tvm_device_region]
.CoVE Host Reclaim TVM Interface Region
[cols="2,3", width=90%, align="center", options="header"]
Expand Down Expand Up @@ -320,7 +328,7 @@ first.

`slot_id` must be between 0 and 7 inclusive.

`cert_addr_out` must be page aligned.
`cert_addr_out` must be 4KB-aligned.

The possible error codes returned in `sbiret.error` are shown below.

Expand Down Expand Up @@ -365,7 +373,7 @@ valid and the rest bits are igored. The last `GET_MEASUREMENT` request must
set `SignatureRequested` bit to request the digital signaure of the measurement
transcript.

Both `msmt_addr_out` and `nonce_addr` must be page aligned.
Both `msmt_addr_out` and `nonce_addr` must be 4KB-aligned.

The possible error codes returned in `sbiret.error` are shown below.

Expand All @@ -390,7 +398,7 @@ struct sbiret sbi_covg_get_device_spdm_attrs(unsigned long device_if_id,
Gets the attributes for the Secure SPDM session between the physical device
hosting `device_if_id` and the TSM.

`spdm_attrs_addr_out` must be page aligned.
`spdm_attrs_addr_out` must be 4KB-aligned.

[source, C]
-------
Expand Down Expand Up @@ -426,7 +434,7 @@ Gets the TDISP interface report for the device interface.
The TSM returns the interface report, as defined by the <<TDISP>> TDI Report
Structure, at the `if_report_out` address.

`if_report_out` must be page aligned.
`if_report_out` must be 4KB-aligned.

The possible error codes returned in `sbiret.error` are shown below.

Expand Down Expand Up @@ -502,7 +510,7 @@ the trusted `TDISP`-reported MMIO regions. The TSM will enable those mappings
if the TVM calls the starts the device interface through the
`sbi_covg_start_interface` function.

All of `gpa_addr`, `hpa_addr` and `size` values must be page aligned.
All of `gpa_addr`, `hpa_addr` and `size` values must be 4KB-aligned.

The possible error codes returned in `sbiret.error` are shown below.

Expand Down
Loading