specifications: Explicitly call out the unbinding flows #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameo
force-pushed
the
topic/lifecycle
branch
7 times, most recently
from
bc02d1c
to
74015b9
Compare
sameo
commented
Apr 16, 2024
| confidential data and abort any outstanding DMA requests, as described in the | ||
| xref:interface-unbinding[Interface Unbinding] section. Implicit TDI unbinding | ||
| from the host supervisor domain manager represents a security threat that is part | ||
| of the xref:05-security_model.adoc#security-model[CoVE-IO threat model] scope. |
There was a problem hiding this comment.
Both TSM and DSM must guarantee TVM confidentiality
There was a problem hiding this comment.
@jyao1 Changes applied. Let me know if that looks good to you.
And refer to the threat model from the high level device and interface lifecycle section. Fixes riscv-non-isa#89 Signed-off-by: Samuel Ortiz <[email protected]>
jyao1
approved these changes
Apr 16, 2024
rsahita
reviewed
Apr 18, 2024
Comment on lines
+903
to
+904
| situation, both the DSM and the TSM must protect the confidentiality and | ||
| integrity of the TVM assets. |
There was a problem hiding this comment.
any ref/example on how that is done - e.g. on subsequent use of the TDI, the DSM would enforce it would transition into the error state; also what about in-flight transactions in that case?
rsahita
reviewed
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And refer to the threat model from the high level device and interface lifecycle section.
Fixes #89