add description for key update. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameo
reviewed
Apr 15, 2024
|
|
||
| In TEE-IO architecture, there are 2 sessions established between the host TSM | ||
| and the device: SPDM session and IDE session. Both sessions use AES-GCM-256 | ||
| keys to protect the data. As such, the host software needs to update the |
There was a problem hiding this comment.
Suggested change
| keys to protect the data. As such, the host software needs to update the | |
| keys to protect the data. As such, the host supervisor domain manager needs to update the |
There was a problem hiding this comment.
Also, is this a needs or a must ?
There was a problem hiding this comment.
I don't think we can put mandatory requirement for an untrusted software.
jyao1
force-pushed
the
key_update
branch
2 times, most recently
from
03395da
to
25c2183
Compare
sameo
reviewed
Apr 16, 2024
Signed-off-by: Jiewen Yao <[email protected]>
sameo
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #55
Fix #53