Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: detailed error messages for cases when resume operation fails #1165

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

aap-sc
Copy link
Collaborator

@aap-sc aap-sc commented Nov 13, 2024

This change aims to provide more context in case if resume operation fails. Before the change messages were quite confusing.

@aap-sc aap-sc changed the title target/riscv: detailed error messages for cases when resume operation… target/riscv: detailed error messages for cases when resume operation fails Nov 13, 2024
@aap-sc
Copy link
Collaborator Author

aap-sc commented Nov 13, 2024

@JanMatCodasip could you take a look, please?

Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added error messages look all right to me overall.

I have made few smaller comments.

src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
src/target/riscv/riscv-013.c Outdated Show resolved Hide resolved
… fails

This change aims to provide more context in case if resume operation
fails. Before the change messages were quite confusing.
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Collaborator

@en-sc en-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed internally).

@en-sc en-sc merged commit f51900b into riscv-collab:riscv Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants