making it build in intellij #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
approved these changes
Jun 5, 2023
|
what about deleting the code of the modules that you disabled ? it is useless and misleading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our branch can't be used to build/deploy flink most of the changes just exclude parts of the project.
There were a few problems - dependencies that no longer exist on maven central, sun-jdk specific code etc. Some modules just got commented out, a few tests just deleted to not deal with figuring out what's wrong there.
With changes in project settings (jdk 11 + set output path), plus unchecked "use release" for java compiler, activated profile "java11-target", and these changes I was able to build the project in intellij
mvn clean install -Drat.skip=true -Dcheckstyle.skip=true -DskipTests -P java11-targetworked from cli tooContext: https://datastax.slack.com/archives/C04U1EMNTU3/p1685666444798889?thread_ts=1685647168.573669&cid=C04U1EMNTU3