Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore SSL verification option added #175

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

joroto
Copy link

@joroto joroto commented Jan 24, 2024

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

Description

Added the option to ignore SSL verification as this can cause issues on some websites with bad configurations.

Testing

Tested with the link from 171, works as expected.

@soloturn
Copy link

thank you so much! would it be possible to have a anme like ssl verify off instead?

@joroto
Copy link
Author

joroto commented Mar 12, 2024

Is only the checkbox text enough or do you prefer for it to be renamed throughout the code?

@soloturn
Copy link

if you do not mind too much, rename in the code. it makes searching for it and not overlooking instances a little easier.

@soloturn soloturn force-pushed the main branch 6 times, most recently from 9cdfe51 to bce4ddd Compare March 21, 2024 06:56
@joroto
Copy link
Author

joroto commented Jul 28, 2024

@soloturn done. I am not sure what #186 point is but I see you have a question there, yes, the issue was motherless urls have an issue with their certificate which was causing the rip to fail.

This new option provides the ability to ignore certificate validation. I checked it by trying to rip a motherless url with and without the option enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement Request] Add option: don't validate the server's certificate
2 participants