-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds protection against duplicate url #162
base: main
Are you sure you want to change the base?
Adds protection against duplicate url #162
Conversation
this does not merge clean, you mind having a look? |
@Undid-Iridium merged the other pr and testing fails, have a look on the "actions" tab, e.g. i created a branch "develop" where all your commits still are. main should be fixed to build and test and thus create a release now. on github server it is headless, so ui test would fail. marked them flaky so they not execute: |
Sorry - I'll update this to fix that (adding flaky per your suggestion) |
would you be so kind to squash your commits into one? e.g. on the command line? |
322159a
to
fd4859e
Compare
fd4859e
to
b0454e2
Compare
# Conflicts: # src/test/java/com/rarchives/ripme/tst/ripper/rippers/ChanRipperTest.java
Unfortunately, squashing after merging main into my branch was a bad idea. I unfortunately put myself in a position where the tree history was too tangled. Rebuilt branch based on main since it took 2 minutes versus the last 30 trying to get the squash to play nice. |
9cdfe51
to
bce4ddd
Compare
Category
This change is exactly one of the following (please change
[ ]
to[x]
) to indicate which:Description
Instead of keep URL in box, it removes it and issues warnings that the url is already slated to being ripped. Also changed the if condition
Main
Branch
Testing
Required verification:
mvn test
(there are no new failures or errors).Optional but recommended: