Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps; implement chombo ranking limit #218

Merged
merged 1 commit into from
Jan 14, 2024
Merged

chore: bump deps; implement chombo ranking limit #218

merged 1 commit into from
Jan 14, 2024

Conversation

m4tx
Copy link
Member

@m4tx m4tx commented Jan 14, 2024

The limit is to avoid Discord complaining about embed being too large (Invalid Form Body (data.embeds.0.fields: Must be 25 or fewer in length.)).

@m4tx m4tx requested review from seqre and Iipin January 14, 2024 03:23
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (1f8c1f5) 45.38% compared to head (bf98fdc) 44.85%.

Files Patch % Lines
chombot-kcc/src/slash_commands/chombo.rs 0.00% 14 Missing ⚠️
chombot-kcc/src/main.rs 0.00% 11 Missing ⚠️
chombot/src/main.rs 0.00% 8 Missing ⚠️
chombot/src/tournament_watcher.rs 0.00% 8 Missing ⚠️
chombot-common/src/discord_utils.rs 0.00% 4 Missing ⚠️
chombot-common/src/slash_commands/score.rs 0.00% 3 Missing ⚠️
chombot-common/src/slash_commands/hand.rs 0.00% 2 Missing ⚠️
chombot-kcc/src/slash_commands/pasta/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   45.38%   44.85%   -0.54%     
==========================================
  Files          22       22              
  Lines        1430     1447      +17     
==========================================
  Hits          649      649              
- Misses        781      798      +17     
Flag Coverage Δ
rust 44.85% <17.74%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Iipin Iipin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great read, lgtm&approve

@m4tx m4tx merged commit 6b3d4de into master Jan 14, 2024
5 of 7 checks passed
@m4tx m4tx deleted the bump-deps branch January 14, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants