Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I'm using pymitter in a couple of projects and I'm really missing the type hints. So this is my attempt to fix this problem.
What I did:
Tree.add_listener
method, where I had to leave sometype: ignore
directives. I believe it is fixable, but requires some refactoring.mypy
checks compatible with Python 3.7, so I've extended the test matrix.py.typed
marker file, which is required for type hinted packages.object
inheritance (which isn't required, I believe, since Python 3).Please note that I had to introduce a breaking change - the
ttl
parameter ofon
andon_any
methods had to become a keyword argument, breaking callers who pass it as a positional argument. This way I could make use of@overload
to more accurately describe signatures both for decorated and non-decorated usage.