Skip to content

Commit

Permalink
Revert "Fixed excessive String concatenations in loop"
Browse files Browse the repository at this point in the history
This reverts commit 7009e54.
  • Loading branch information
gbevin committed Oct 10, 2023
1 parent 400bb13 commit f53c73c
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -220,17 +220,13 @@ protected void executePopulateProjectStructure()
for (var entry : project_.dependencies().entrySet()) {
build_template.blankValue("dependencies");

var version_string = new StringBuilder(0);
for (var dependency : entry.getValue()) {
build_template.setValue("groupId", dependency.groupId());
build_template.setValue("artifactId", dependency.artifactId());
var version = dependency.version();
version_string.setLength(0);
version_string.append(version.major()).append(',')
.append(version.minor()).append(',')
.append(version.revision());
var version_string = version.major() + "," + version.minor() + "," + version.revision();
if (!version.qualifier().isEmpty()) {
version_string.append(",\"" ).append(version.qualifier()).append('"');
version_string += ",\"" + version.qualifier() + "\"";
}
build_template.setValue("version", version_string);
build_template.appendBlock("dependencies", "dependency");
Expand Down

0 comments on commit f53c73c

Please sign in to comment.