Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users monitoring to riemann-health #226

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Add users monitoring to riemann-health #226

merged 1 commit into from
Aug 17, 2022

Conversation

smortex
Copy link
Member

@smortex smortex commented Aug 16, 2022

Default to low thresholds because we don't expect users to be signed-in on servers, but this can be tuned the usual way with some flags.

For now, this check is not enabled by default (see #227 for a discussion about this).

@smortex smortex added the enhancement New feature or request label Aug 16, 2022
@smortex smortex changed the title Add support for users monitoring Add users monitoring to riemann-health Aug 16, 2022
@smortex smortex marked this pull request as draft August 16, 2022 20:07
Default to low thresholds because we don't expect users to be signed-in
on servers, but this can be tuned the usual way with some flags.

For now, this check is not enabled by default.
@smortex smortex marked this pull request as ready for review August 16, 2022 20:08
Copy link
Member

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit meh about the value of users monitoring overall but I don't think it hurts to add it.

@jamtur01 jamtur01 merged commit 3ba5ff7 into main Aug 17, 2022
@smortex smortex deleted the users branch August 27, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants