Add Ruby 3.3 to the CI test matrix #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.3 is available and some systems will ship with it soon, so make sure the test suite is run with this version of Ruby so that we can spot issues before they hit everyone.
They are basically in two categories:
1. Variables with name ending with digits. This is generaly not a
good idea but in the test suite we want to send messages in order
and numbering them help, so silence the related offences;
2. Test that do not explicitly run expectations. Some run a function
that had the expectation, so this was refactored to remove the
extra layer that caused rubocop confusion; other just made sure
that to expection was raised, but did not explicitly tested for it,
so explicitly state that we expect no exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 is available and some systems will ship with it soon, so make
sure the test suite is run with this version of Ruby so that we can spot
issues before they hit everyone.