FIXES #34

[andrusieczko]

Moving IBlockingDeref and IDeref from clojure.lang to com.aphyr.riemann.client solves the JarHell.

[aphyr]

Pretty sure this is gonna break the Clojure client and Riemann itself. Have you tested?
On Feb 3, 2016 01:35, Karol Andrusieczko [email protected] wrote:Moving IBlockingDeref and IDeref from clojure.lang to com.aphyr.riemann.client solves the JarHell.

You can view, comment on, or merge this pull request online at:
  #69

Commit Summary
FIXES #34

File Changes

R
riemann-java-client/src/main/java/com/aphyr/riemann/client/IBlockingDeref.java
(2)

R
riemann-java-client/src/main/java/com/aphyr/riemann/client/IDeref.java
(2)

M
riemann-java-client/src/main/java/com/aphyr/riemann/client/IPromise.java
(2)

Patch Links:
https://github.com/aphyr/riemann-java-client/pull/69.patchhttps://github.com/aphyr/riemann-java-client/pull/69.diff

—Reply to this email directly or view it on GitHub.

[andrusieczko]

Hey,

I ran mvn install, all the tests passed. Then I used it in my app with riemann-clojure-client and quite a lot of clojure libraries (running on clojure 1.8 and Java 1.8) and everything seems to be working fine.

I haven't done any more thorough tests though.

Cheers,
Karol

[aphyr]

Did you rebuild riemann-clojure-client with your version of riemann-java-client? It relies on Clojure.lang.IDeref so I'd be surprised if this works haha.
On Feb 3, 2016 2:53 PM, Karol Andrusieczko [email protected] wrote:Hey,

I ran mvn install, all the tests passed. Then I used it in my app with riemann-clojure-client and quite a lot of clojure libraries (running on clojure 1.8 and Java 1.8) and everything seems to be working fine.

Cheers,
Karol

—Reply to this email directly or view it on GitHub.

[andrusieczko]

I did that, yes, but now I noticed that the test are not passing, you're probably right that it's not actually working fine.

So the fix should be done with Java Proxy then as you suggested. Any plans to fix it? :)

[aphyr]

I am completely overwhelmed; you're gonna have to fix this.

[jamtur01]

Closing for now unless someone wishes to fix.