Add Ruby 3.3 to the test matrix #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.2 deprecated `File#exists?` in favor of `File#exist?`, and Ruby 3.2 removed the deprecated method. We need to use the "new" method to run on Ruby 3.2.
This old bundle is broken with current ruby. Allow to bundle using the latest version of the dependencies that match the Gemfile. This should allow the test suite to run.
While here, quote versions, as `3.0` is considered as a floating point value, and GitHub actions get confused when the fractional part of a number is 0 and understand `3`, which in turn use the latest version of Ruby 3.x (so, yes, this was already testing against Ruby 3.3 and in fact add tests for 3.0, but don't tell anyone 😉).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While here, quote versions, as
3.0is considered as a floating point value, and GitHub actions get confused when the fractional part of a number is 0 and understand3, which in turn use the latest version of Ruby 3.x (so, yes, this was already testing against Ruby 3.3 and in fact add tests for 3.0, but don't tell anyone 😉).Also include: