Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux 64bit GCC compilation, adjust Makefile #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CounterPillow
Copy link

There are still lots of warnings, mostly related to dangerous casts, but it compiles and is able to show the help output with GCC 5.2.0.

Makefile

  • COMPILER_OPTIONS was replaced with the standard convention of CXXFLAGS for C++ files.
  • LINKER_OPTIONS was replaced with the standard convention of LDFLAGS.
  • g++ was replaced with $(CXX), which by default is g++ for GNU Make.
  • all was made a phony target due to not creating an output named "all".
  • A phony target clean was added, which calls $(RM) (equivalent to rm -f in GNU Make by default) on the output files.
  • Replaced -march=core2 with -march=native. Closes issue -march=core2 shouldn't be in the make file #13.

Code

  • Fix a number of compilation errors by turning calls to members in some places to dependant(?) calls by prefixing this->.
  • Turn is_power_of_2 into a template to solve ambiguity errors related to calling it with size_t.
  • Explicitly cast a size_t to uint32 in one place to resolve an ambiguity error. Might be incorrect, but I'm not knowledgeable enough with C++ to propose a cleaner fix.
  • Systems other than Windows can have 64 bits too.

All in all, most likely closes issue #10.

@MAnyKey
Copy link

MAnyKey commented Apr 25, 2016

It is a good pull request. Why isn't it merged?

@MAnyKey MAnyKey mentioned this pull request Apr 25, 2016
8 tasks
@CounterPillow
Copy link
Author

I assume because the project is dead.

@richgel999
Copy link
Owner

We're busy with several projects that have paying customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants