Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable tie_embedding #85

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: disable tie_embedding #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aria/model/configuration_aria.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,13 @@ def __init__(
},
ignore_index=-100,
image_token_index=32000,
tie_word_embeddings=False,
**kwargs,
):
super().__init__(**kwargs)
self.ignore_index = ignore_index
self.image_token_index = image_token_index

self.tie_word_embeddings = tie_word_embeddings
attn_implementation = kwargs.pop("attn_implementation", None)

# Set the default attention implementation to flash_attention_2 if not specified
Expand Down
4 changes: 2 additions & 2 deletions aria/model/modeling_aria.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,11 @@ def get_input_embeddings(self) -> nn.Module:
def set_input_embeddings(self, value):
"""Set the input embeddings for the language model."""
self.language_model.set_input_embeddings(value)

def get_output_embeddings(self):
"""Retrieve the output embeddings from the language model."""
return self.language_model.get_output_embeddings()

def set_output_embeddings(self, value):
"""Set the output embeddings for the language model."""
self.language_model.set_output_embeddings(value)
Expand Down