Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:publish bundle image with latest tag #431

Closed
wants to merge 1 commit into from

Conversation

lihongyan1
Copy link
Contributor

Catalog image didn't build for a long time for issue #222, it suggest to use bundle image to install operator, so publish bundle iamge with latest tag, so that refer the latest image easily during test

@lihongyan1 lihongyan1 requested a review from a team as a code owner March 12, 2024 09:04
@lihongyan1 lihongyan1 requested review from danielmellado and slashpai and removed request for a team March 12, 2024 09:04
@openshift-ci openshift-ci bot requested a review from sthaha March 12, 2024 09:04
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lihongyan1
Once this PR has been reviewed and has the lgtm label, please assign slashpai for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jan--f
Copy link
Collaborator

jan--f commented Mar 12, 2024

The lack of catalog images is my fault. The publish action is faling since we moved to olm.csv.metadata in the catalog in #410. I wasn't aware that impacted our OCP tests, looking into it now. Not sure this change here is a sustainable fix.

@jan--f
Copy link
Collaborator

jan--f commented Mar 12, 2024

#432 should fix the issue.

@lihongyan1
Copy link
Contributor Author

#432 should fix the issue.

#432 can't fix the issue, it doesn't make sense to test a release image in olm-catalog branch. #222 is not fixed and for every PR merged to main still has pipeline error, such as the following action, failed to publish olm development
https://github.com/rhobs/observability-operator/actions/runs/8254817309
https://github.com/rhobs/observability-operator/actions/runs/8254817309/job/22580255690

Catalog image didn't build for a long time for issue
 rhobs#222
The issue suggest to use bundle image to install operator
Publish bundle iamge with latest tag to refer the image easily
Copy link

openshift-ci bot commented Mar 13, 2024

@lihongyan1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/observability-operator-e2e 45016cc link true /test observability-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lihongyan1
Copy link
Contributor Author

lihongyan1 commented Mar 14, 2024

#432 fixs the issue. So I closed the pr

@lihongyan1 lihongyan1 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants