Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update M2K notifications #52

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Update M2K notifications #52

merged 1 commit into from
Jan 30, 2024

Conversation

gabriel-farache
Copy link
Collaborator

Update M2K notifications:

  • Add name of the branch and repo URL when sending successful notification
  • Replace markdown with actions for move2kube Q&A waiting

Solves:

move2kube/m2k.sw.yml Outdated Show resolved Hide resolved
@@ -238,6 +231,24 @@ components:
type: string
message:
type: string
actions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have to wait to one of two: PR to the generator or Pr to the notification plugin, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it on the main of janus idp (https://github.com/janus-idp/backstage-plugins/blob/main/plugins/notifications-backend/src/openapi.yaml) is it not already merged? There are so many projects to propagate a change in a given project, I am totally lost as to where it should be merged to be available to us (the showcase I guess?)

@gabriel-farache
Copy link
Collaborator Author

/hold for @mareklibra to public notification plugin as dynamic plugin

@gabriel-farache gabriel-farache marked this pull request as ready for review January 24, 2024 09:58
@gabriel-farache
Copy link
Collaborator Author

tested locally, it works:

 {
    "id": "dbf44f33-fd61-44b0-9af1-36f9448b5055",
    "created": "2024-01-24 09:54:54",
    "isSystem": true,
    "readByUser": false,
    "origin": "Move2Kube Workflow",
    "title": "Transformation  waiting for Q&A",
    "message": "Please go to your move2kube instance and answer the questions in order to continue the Move2Kube workflow",
    "topic": "Move2Kube Workflow",
    "actions": [
      {
        "id": "33a68612-bde6-42ea-ba1c-b94043c1be1a",
        "url": "http://move2kube-svc.default.svc.cluster.local:8080/workspaces/1984fcca-5ddd-4c55-982c-dde02e2fbc00/projects/eb566284-9134-4b2e-ad3f-e540d49ad208/outputs/83d16f0f-3ff6-44e3-a917-a838ab1480e5",
        "title": "Move2Kube waiting Q&A"
      }
    ]
  },

@masayag
Copy link
Collaborator

masayag commented Jan 30, 2024

/hold for @mareklibra to public notification plugin as dynamic plugin

@gabriel-farache this can be unhold now.

@gabriel-farache
Copy link
Collaborator Author

/unhold

@gabriel-farache
Copy link
Collaborator Author

rhdhorchestrator/orchestrator-helm-chart#45 is including the notification plugin as a dynamic one in the charts

@masayag masayag merged commit 4fae4bd into main Jan 30, 2024
2 checks passed
@gabriel-farache gabriel-farache deleted the m2k_notifications branch January 31, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants