-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update M2K notifications #52
Conversation
@@ -238,6 +231,24 @@ components: | |||
type: string | |||
message: | |||
type: string | |||
actions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will have to wait to one of two: PR to the generator or Pr to the notification plugin, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it on the main of janus idp (https://github.com/janus-idp/backstage-plugins/blob/main/plugins/notifications-backend/src/openapi.yaml) is it not already merged? There are so many projects to propagate a change in a given project, I am totally lost as to where it should be merged to be available to us (the showcase I guess?)
dba1dcf
to
0c9ea12
Compare
/hold for @mareklibra to public notification plugin as dynamic plugin |
tested locally, it works:
|
@gabriel-farache this can be unhold now. |
/unhold |
rhdhorchestrator/orchestrator-helm-chart#45 is including the notification plugin as a dynamic one in the charts |
Update M2K notifications:
actions
for move2kube Q&A waitingSolves: