added workflow to detect whitespaces #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-farache
approved these changes
Sep 24, 2024
Comment on lines
+4
to
+7
| pull_request: | ||
| push: | ||
| branches: [ "main" ] | ||
| paths: |
There was a problem hiding this comment.
I merged too fast, this needs to be
pull_request:
branches:
- main
otherwise the CI will only be executed when pushing on main, so after the PR is merged
There was a problem hiding this comment.
You sure? the workflow ran for me just now on this PR
https://github.com/parodos-dev/serverless-workflows/pull/422/checks
There was a problem hiding this comment.
ah, indeed an empty pull_request means that every PR will execute the CI (https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple workflow to detect whitespaces upon changes in application.properties files. This will ensure that application.properties files won't get merged in a format that may hinder their rendering as k8s resources.