Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging properties to all workflows #411

Merged
merged 3 commits into from
Sep 18, 2024
Merged

added logging properties to all workflows #411

merged 3 commits into from
Sep 18, 2024

Conversation

ElaiShalevRH
Copy link
Collaborator

Copy link
Collaborator

@gabriel-farache gabriel-farache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElaiShalevRH You missed greeting and request-vm-cnv and create-ocp-project workflows
@masayag Maybe we should create a subfolder 'workflows' and put all workflows in it so we don't get lost with all non-related folder that come in between the workflows folders when listed in alphabetical order

@masayag
Copy link
Collaborator

masayag commented Sep 16, 2024

@masayag Maybe we should create a subfolder 'workflows' and put all workflows in it so we don't get lost with all non-related folder that come in between the workflows folders when listed in alphabetical order

@gabriel-farache that's a good idea. this entitle a jira issue on its own, since it isn't only moving the folders, but also adapting all of the scripts and github actions.

@@ -130,13 +131,21 @@
<version>2.10.0</version>
<scope>test</scope>
</dependency>

<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to add the same to the software template.

Copy link
Collaborator

@gabriel-farache gabriel-farache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@gabriel-farache gabriel-farache merged commit 8e07716 into main Sep 18, 2024
28 of 30 checks passed
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants