adding support for large YAML files as input #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaiShalevRH
force-pushed
the
dockerfile-change
branch
from
0e7d443 to
59b44e1
Compare
ElaiShalevRH
force-pushed
the
dockerfile-change
branch
from
59b44e1 to
b6aa7ed
Compare
gabriel-farache
approved these changes
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
This was referenced Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
This was referenced Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a build time param for the serverless workflow dockerfile that allows passing YAML input files to a workflow with an unlimited size. This change comes in handy when we might use large openAPI spec files.
This change has been tested using a custom image built using this suggested change, and validated that the workflow does accept the arge input.
A reproducer for this fix can be seen here.
For full discretion, using large input files with this parameter may cause the workflow execution time to be slower.