-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop the global build-arg QUARKUS_EXTENSIONS from the makefile #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
going to add some change in the containerfile to get all the images built |
rgolangh
force-pushed
the
remove-quarkus-extensions-from-makefile
branch
from
September 11, 2024 11:43
cfa8de2
to
1575fb6
Compare
Workflows were missing persistency since the introduction of build-arg usage in the makefile. This is not really used and sending an empty value override the value in argfile. Removing as this is not used and is too clever. Signed-off-by: Roy Golan <[email protected]>
I see usePersistence=true in the build logs
|
masayag
approved these changes
Sep 11, 2024
I confirm data is being stored in workflow's schema. |
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
This was referenced Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
This was referenced Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 11, 2024
gabriel-farache
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 13, 2024
gabriel-farache
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 13, 2024
gabriel-farache
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 13, 2024
gabriel-farache
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 13, 2024
gabriel-farache
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflows were missing persistency since the introduction of build-arg
usage in the makefile.
This is not really used and sending an empty value override the value in
argfile. Removing as this is not used and is too clever.
Signed-off-by: Roy Golan [email protected]