Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the global build-arg QUARKUS_EXTENSIONS from the makefile #406

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

rgolangh
Copy link
Collaborator

Workflows were missing persistency since the introduction of build-arg
usage in the makefile.

This is not really used and sending an empty value override the value in
argfile. Removing as this is not used and is too clever.

Signed-off-by: Roy Golan [email protected]

@rgolangh
Copy link
Collaborator Author

going to add some change in the containerfile to get all the images built

@rgolangh rgolangh force-pushed the remove-quarkus-extensions-from-makefile branch from cfa8de2 to 1575fb6 Compare September 11, 2024 11:43
Workflows were missing persistency since the introduction of build-arg
usage in the makefile.

This is not really used and sending an empty value override the value in
argfile. Removing as this is not used and is too clever.

Signed-off-by: Roy Golan <[email protected]>
@rgolangh
Copy link
Collaborator Author

I see usePersistence=true in the build logs

2024-09-11T11:44:34.0974593Z [INFO] Performed addonsConfig discovery, found: AddonsConfig{usePersistence=true, useTracing=false, useMonitoring=false, usePrometheusMonitoring=false, useCloudEvents=true, useExplainability=false, useProcessSVG=false, useEventDrivenDecisions=false, useEventDrivenRules=false}

@masayag
Copy link
Collaborator

masayag commented Sep 11, 2024

I confirm data is being stored in workflow's schema.

@masayag masayag merged commit eb63062 into main Sep 11, 2024
11 of 15 checks passed
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 11, 2024
gabriel-farache pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 13, 2024
gabriel-farache pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 13, 2024
gabriel-farache pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 13, 2024
gabriel-farache pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 13, 2024
gabriel-farache pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants