Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLPATH-1555: Repo requirements for MTA workflow #354

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

jenniferubah
Copy link
Contributor

@jenniferubah jenniferubah commented Aug 7, 2024

Listed out all the potential git repo requirements for MTA workflow and added it to all the docs for various MTA versions.

@masayag masayag requested a review from gabriel-farache August 7, 2024 16:13
@rgolangh
Copy link
Collaborator

rgolangh commented Aug 8, 2024

Why is a repository considered a requirement? I find this confusing.

jenniferubah referenced this pull request in jenniferubah/serverless-workflows Aug 8, 2024
@jenniferubah
Copy link
Contributor Author

Why is a repository considered a requirement? I find this confusing.

The main idea is to give the user a guideline on what type of git repo should be created when testing the MTA workflow.
I ran into a scenario where I wasn't sure what repo I could use when testing the workflow and QE team ran into same, hence the ticket: FLPATH-1555

@gciavarrini
Copy link
Collaborator

Why is a repository considered a requirement? I find this confusing.

@rgolangh It helps to understand how to use MTA and to reduce the cognitive complexity for the user.
IMO, there is a value in including basic information for the user.

In addition, this item FLPATH-1555 has been open by our QE team.

FYI @y-first

Comment on lines 15 to 23
# Requirement for Repository
- Create a git repo with a simple Java class. It can either be public or private.
Currently, MTA supports mostly Java projects.
- If repository is private, refer to [configuring repository][4] on how to set up credentials on MTA.
- Note: When creating the source control credentials in MTA, ensure to input personal access token in the password field.
Refer to [personal access token] [5] on how to create personal access token (classic) on GitHub.
- Also, git url address must use https. Refer to [about remote repositories][6] for more details.
- If the repo is public, no further configuration is needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of copy & paste this paragraph in multiple README, can we consider adding the paragraph here and then only add a link in each mta-v* README? Or maybe it's not a good place?

@rgolangh
Copy link
Collaborator

rgolangh commented Aug 8, 2024

Why is a repository considered a requirement? I find this confusing.

@rgolangh It helps to understand how to use MTA and to reduce the cognitive complexity for the user. IMO, there is a value in including basic information for the user.

In addition, this item FLPATH-1555 has been open by our QE team.

FYI @y-first

User's done need to create a repo, they need to analyze it. they should already have it. If this is for QE documentation then this is a bit of a different thing - the documentation addition here is addressing a different persona, and not the end user.
I think is valuable to include that a repo should be accessible (even though it is arguably obvious)

@rgolangh
Copy link
Collaborator

rgolangh commented Aug 8, 2024

A repo that is private will not work if the MTA admin didn't set the credentials for it. It is worth to link to the Konveyor tackle(the mta upstream) docs and MTA docs

@masayag
Copy link
Collaborator

masayag commented Aug 11, 2024

I suggest moving the new requirement into a "Testing" section where the user can provide an existing repository (an example can be provided, e.g. https://github.com/spring-projects/spring-petclinic) or create a new one based on the requirements listed in this PR.
In addition, the target gh-pages for the MTA workflow is https://github.com/parodos-dev/serverless-workflows-config/tree/gh-pages/docs/mta
which we usually refer to as source-of-truth to avoid duplicating documentation between repositories.

@masayag masayag merged commit 17f1e3e into rhdhorchestrator:main Aug 12, 2024
6 of 10 checks passed
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Aug 12, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Aug 12, 2024
orchestrator-ci pushed a commit to rhdhorchestrator/serverless-workflows-config that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants