Set severity when sending notification #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydayagi
approved these changes
Aug 1, 2024
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
feat/set_severity
branch
from
93bd355 to
01d9923
Compare
Signed-off-by: gabriel-farache <[email protected]>
masayag
approved these changes
Aug 1, 2024
masayag
reviewed
Aug 1, 2024
.github/workflows/mta-v7.x-e2e.yaml
Outdated
|
|
||
| # Disable persistence for e2e tests | ||
| yq e '.spec.persistence = {}' -i manifests/01-sonataflow_mta-analysis-v7.yaml | ||
| yq e '.spec.persistence = {}' -i manifests/04-sonataflow_mta-analysis-v7.yaml | ||
| sed -i '/quarkus\.flyway\.migrate-at-start=true/d' manifests/03-configmap_mta-analysis-v7-props.yaml | ||
|
|
||
| echo "manifests/03-configmap_mta-analysis-v7-props.yaml" |
There was a problem hiding this comment.
pls change this to 01-...
01-configmap_mta-analysis-v7-props.yaml
There was a problem hiding this comment.
yeah, there were files missed when upgrading the prefixes
There was a problem hiding this comment.
test still fails, probably misses the patching of the secret. not going to do it now. merging.
There was a problem hiding this comment.
Not sure about that, the MTA V7 e2e tests are failing for quite some time I think https://github.com/parodos-dev/serverless-workflows/actions/workflows/mta-v7.x-e2e.yaml
There was a problem hiding this comment.
so probably more work is required. one day...
masayag
approved these changes
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
This was referenced Aug 1, 2024
Merged
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
This was referenced Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
orchestrator-ci
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
masayag
pushed a commit
to rhdhorchestrator/serverless-workflows-config
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.redhat.com/browse/FLPATH-1553
Set severity when sending notification