Add mount of notification bearer secret in generated CR #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masayag
reviewed
Jul 15, 2024
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
feat/add_notification_bearer_secret
branch
2 times, most recently
from
fa38fa5 to
4153999
Compare
masayag
requested changes
Jul 15, 2024
masayag
reviewed
Jul 15, 2024
gabriel-farache
force-pushed
the
feat/add_notification_bearer_secret
branch
3 times, most recently
from
26410db to
f3891fe
Compare
rgolangh
reviewed
Jul 15, 2024
rgolangh
reviewed
Jul 15, 2024
gabriel-farache
force-pushed
the
feat/add_notification_bearer_secret
branch
from
f3891fe to
a2b3638
Compare
rgolangh
reviewed
Jul 15, 2024
scripts/gen_manifests.sh
Outdated
| @@ -50,6 +45,11 @@ SONATAFLOW_CR=manifests/01-sonataflow_${workflow_id}.yaml | |||
| yq --inplace eval '.metadata.annotations["sonataflow.org/profile"] = "prod"' "${SONATAFLOW_CR}" | |||
|
|
|||
| yq --inplace ".spec.podTemplate.container.image=\"quay.io/orchestrator/serverless-workflow-${workflow_id}:latest\"" "${SONATAFLOW_CR}" | |||
| yq --inplace ".spec.podTemplate.container.envFrom=[{\"secretRef\": { \"name\": \"${workflow_id}-creds\"}}]" "${SONATAFLOW_CR}" | |||
|
|
|||
| if [ "$ENABLE_PERSISTENCE" = false ]; then | |||
There was a problem hiding this comment.
I'm handling this as part of #313
There was a problem hiding this comment.
I was hoping for your pr to be merged first and have the auto merge do its job
But I'll revert this change
masayag
approved these changes
Jul 15, 2024
|
We can push this binary into the tools container image and use it there.
Same for kn
…On Mon, 15 Jul 2024 at 19:06 gabriel-farache ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scripts/gen_manifests.sh
<#315 (comment)>
:
> @@ -15,6 +15,15 @@ else
echo "kn cli already available"
fi
+if [ ! -f kubectl ]; then
Because it will not be in the image we are pulling and if we execute it
locally it will look into the bin path or next to the files, like for kn
—
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGBYHCGVPRBEOQNWJSZEX3ZMPXPHAVCNFSM6AAAAABK4CR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZYGEZTEOBQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
On second thought perhaps using kubectl create just to create a secret is
an overkill
…On Mon, 15 Jul 2024 at 19:20 Roy Golan ***@***.***> wrote:
We can push this binary into the tools container image and use it there.
Same for kn
On Mon, 15 Jul 2024 at 19:06 gabriel-farache ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In scripts/gen_manifests.sh
> <#315 (comment)>
> :
>
> > @@ -15,6 +15,15 @@ else
> echo "kn cli already available"
> fi
>
> +if [ ! -f kubectl ]; then
>
> Because it will not be in the image we are pulling and if we execute it
> locally it will look into the bin path or next to the files, like for kn
>
> —
> Reply to this email directly, view it on GitHub
> <#315 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABGBYHCGVPRBEOQNWJSZEX3ZMPXPHAVCNFSM6AAAAABK4CR2AKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZYGEZTEOBQHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
feat/add_notification_bearer_secret
branch
from
a2b3638 to
03d7d84
Compare
|
reopening => #317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mount of notification bearer secret in generated CR
Closes part of https://issues.redhat.com/browse/FLPATH-1498