Remove hack

Instead using hack to disable persistence, we'll build the worklfow images for testing without persistence. Signed-off-by: Moti Asayag <[email protected]>
rhdhorchestrator · Apr 22, 2024 · aeb5d0c · aeb5d0c
1 parent 15748f2
commit aeb5d0c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/.github/workflows/move2kube-e2e.yaml b/.github/workflows/move2kube-e2e.yaml
@@ -108,8 +108,7 @@ jobs:
           yq  --inplace 'del(.spec.persistence)' manifests/01-sonataflow_m2k.yaml
           # The 'for loop' added due to inconsistency of the generated numbers of the configmaps
           for file in manifests/*-configmap_m2k-props.yaml; do
-            # sed -i '/quarkus\.flyway\.migrate-at-start=true/d' "$file"
-            sed -i 's/quarkus.flyway.migrate-at-start=true/quarkus.datasource.jdbc.url = ""/' "$file"
+            sed -i '/quarkus\.flyway\.migrate-at-start=true/d' "$file"
           done
 
           # deploy the manifests created by the  ${{ steps.build-image.outputs.image }}"                                                                    

diff --git a/.github/workflows/mta-e2e.yaml b/.github/workflows/mta-e2e.yaml
@@ -110,16 +110,7 @@ jobs:
           
           # Disable persistence for e2e tests
           yq e '.spec.persistence = {}' -i manifests/01-sonataflow_mtaanalysis.yaml
-          # sed -i '/quarkus\.flyway\.migrate-at-start=true/d' manifests/02-configmap_mtaanalysis-props.yaml
-          # sed -i '/^data:/a \ \ \ \ quarkus.datasource.jdbc.url = ""' manifests/02-configmap_mtaanalysis-props.yaml
-
-          # The purpose of this ugly hack is to prevent the workflow application start with DB enabled.
-          # While the workflow be responsive for incoming requests, it will also produce warnings since the persistence attributes
-          # are build-time only in Quarkus 3.2. When we'll switch to Quarkus 3.8 we can easily disable persistence by introducing line:
-          # quarkus.datasource.jdbc = false
-          # See https://quarkus.io/guides/datasource#jdbc-and-reactive-datasources-simultaneously and
-          # https://quarkus.io/guides/datasource#quarkus-agroal_quarkus-datasource-jdbc
-          sed -i 's/quarkus.flyway.migrate-at-start=true/quarkus.datasource.jdbc.url = ""/' manifests/02-configmap_mtaanalysis-props.yaml
+          sed -i '/quarkus\.flyway\.migrate-at-start=true/d' manifests/02-configmap_mtaanalysis-props.yaml
 
           echo "manifests/02-configmap_mtaanalysis-props.yaml"
           cat manifests/02-configmap_mtaanalysis-props.yaml