Skip to content

Commit

Permalink
fix move2kube default url value (#386)
Browse files Browse the repository at this point in the history
Signed-off-by: Gloria Ciavarrini <[email protected]>
  • Loading branch information
gciavarrini authored Sep 1, 2024
1 parent 56d2ed9 commit a4cd5d2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/move2kube-e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
kubectl patch configmap/m2k-props \
--type merge \
-p '{"data": {"application.properties" :"move2kube_url=http://move2kube-instance-svc.default.svc.cluster.local:8080\nquarkus.rest-client.move2kube_yaml.url=http://move2kube-instance-svc.default.svc.cluster.local:8080\nquarkus.rest-client.notifications.url=http://orchestrator-backstage.default.svc.cluster.local:7007/"}}'
-p '{"data": {"application.properties" :"move2kube_url=http://move2kube-instance-svc.default.svc.cluster.local:8080\nquarkus.rest-client.move2kube_yaml.url=http://move2kube-instance-svc.move2kube.svc.cluster.local:8080\nquarkus.rest-client.notifications.url=http://orchestrator-backstage.default.svc.cluster.local:7007/"}}'
kubectl delete pod -l "app=m2k"
kubectl get pods -o wide
kubectl wait --for=condition=Ready=true pods -l "app=m2k" --timeout=1m
Expand Down
2 changes: 1 addition & 1 deletion make.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on the specific git service provider (e.g. GitHub rather than Bitbucket).
* Linux OS
* Container registry credentials to publish the generated image

The actuall implementation is delegated to shell scripts localted under the [scripts](./scripts/) folder that run
The actual implementation is delegated to shell scripts located under the [scripts](./scripts/) folder that run
in a containerized image including all the required dependencies: there's no need to install any other
tool in the local environment.

Expand Down
4 changes: 2 additions & 2 deletions move2kube/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ mp.messaging.incoming.kogito_incoming_stream.path=/
mp.messaging.incoming.kogito_incoming_stream.method=POST

# This property is used when sending the notification while waiting for Q&A
move2kube_url=${MOVE2KUBE_URL:http://move2kube-svc.default.svc.cluster.local:8080}
move2kube_url=${MOVE2KUBE_URL:http://move2kube-svc.move2kube.svc.cluster.local:8080}
move2kube_get_plan_max_retries=${MOVE2KUBE_GET_PLAN_MAX_RETRIES:10}

# This property is used to send requests to the move2kube instance
quarkus.rest-client.move2kube_yaml.url=${MOVE2KUBE_URL:http://move2kube-svc.default.svc.cluster.local:8080}
quarkus.rest-client.move2kube_yaml.url=${MOVE2KUBE_URL:http://move2kube-svc.move2kube.svc.cluster.local:8080}

# This property is used to send requests to the backstage notification plugin
quarkus.rest-client.notifications.url=${BACKSTAGE_NOTIFICATIONS_URL:http://backstage-backstage.rhdh-operator}
Expand Down

0 comments on commit a4cd5d2

Please sign in to comment.