Introduce new monitoring flag #194
Conversation
Signed-off-by: Jude Niroshan <[email protected]>
JudeNiroshan
force-pushed
the
swf-monitoring
branch
from
51a4775 to
7e21178
Compare
| @@ -28,8 +28,8 @@ The following table lists the configurable parameters of the Orchestrator chart | |||
| | `rhdhOperator.secretRef.github.token` | Key in the secret with name defined in the 'name' field that contains the value of the authentication token as expected by GitHub. Required for importing resource to the catalog, launching software templates and more. Defaults to 'GITHUB_TOKEN', empty for not available. | `"GITHUB_TOKEN"` | | |||
| | `rhdhOperator.secretRef.github.clientId` | Key in the secret with name defined in the 'name' field that contains the value of the client ID that you generated on GitHub, for GitHub authentication (requires GitHub App). Defaults to 'GITHUB_CLIENT_ID', empty for not available. | `"GITHUB_CLIENT_ID"` | | |||
| | `rhdhOperator.secretRef.github.clientSecret` | Key in the secret with name defined in the 'name' field that contains the value of the client secret tied to the generated client ID. Defaults to 'GITHUB_CLIENT_SECRET', empty for not available. | `"GITHUB_CLIENT_SECRET"` | | |||
| | `rhdhOperator.secretRef.k8s.clusterToken` | Key in the secret with name defined in the 'name' field that contains the value of the Kubernetes API bearer token used for authentication. Defaults to 'K8S_CLUSTER_URL', empty for not available. | `"K8S_CLUSTER_URL"` | | |||
| | `rhdhOperator.secretRef.k8s.clusterUrl` | Key in the secret with name defined in the 'name' field that contains the value of the API URL of the kubernetes cluster. Defaults to 'K8S_CLUSTER_TOKEN', empty for not available. | `"K8S_CLUSTER_TOKEN"` | | |||
| | `rhdhOperator.secretRef.k8s.clusterToken` | Key in the secret with name defined in the 'name' field that contains the value of the API URL of the kubernetes cluster. Defaults to 'K8S_CLUSTER_TOKEN', empty for not available. | `"K8S_CLUSTER_TOKEN"` | | |||
There was a problem hiding this comment.
those 2 lines seem to be be mixed, but not an issue of this PR.
Pls rebased (I fixed it in another PR which is merged)
| @@ -32,6 +32,9 @@ spec: | |||
| limits: | |||
| memory: {{ .Values.orchestrator.sonataPlatform.resources.limits.memory }} | |||
| cpu: {{ .Values.orchestrator.sonataPlatform.resources.limits.cpu }} | |||
| {{- if .Values.monitoring.enabled }} | |||
| monitoring: true | |||
There was a problem hiding this comment.
this isn't part of the platform's spec:
https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/api/v1alpha08/sonataflowplatform_types.go#L34
There was a problem hiding this comment.
@JudeNiroshan is there a requirement to contribute a feature for the sonataflow operator for this?
There was a problem hiding this comment.
Yes, there is an epic in Sonataflow Operator -> apache/incubator-kie-kogito-serverless-operator#461
But it is not ready yet. Maybe we can ignore this CR condition until we have the operator modification.
There was a problem hiding this comment.
I think we should wait for the epic to be completed and available for testing before introducing the monitoring attribute to this PR.
We can keep this one as draft for the meantime. WDYT?
There was a problem hiding this comment.
Yeah, I agree with you. I have already marked this as a draft PR. Once I have the serverless-workflows changes merged, I can do the manual testing on an already deployed helm chart.(Without the CR if condition)
|
Closing this PR. This PR will have to be recreated againt https://github.com/parodos-dev/orchestrator-helm-operator |
Depends on
apache/incubator-kie-kogito-serverless-operator#461
Introduced a new monitoring flag for the orchestrator helm chart for OCP.
Enabling this flag will install Prometheus and Grafana operators.