Issue #28 - Updated existing tests to use completed_successfully() in…

…stead of checking return code

integration/int_3Ri_2BhaRi2_3Re_2BhaRe3/test_address_translation.py

@@ -106,8 +106,8 @@ def test_address_translation_sending(self, address, translates_to, sender, broke
         sender.execution.wait()
 
         # Validating sender completed successfully
-        logging.debug("Sender exit code: %s - timed out: %s" %
-                      (sender.execution.returncode,
+        logging.debug("Sender completed successfully: %s - timed out: %s" %
+                      (sender.execution.completed_successfully(),
                        sender.execution.timed_out))
         assert sender.execution.completed_successfully()
 
@@ -173,8 +173,8 @@ def test_address_translation_receiving(self, address, translates_to, receiver, b
         receiver.execution.wait()
 
         # Validating results
-        logging.info("Receiver exit code: %s - timed out: %s" %
-                     (receiver.execution.returncode,
+        logging.info("Receiver completed successfully: %s - timed out: %s" %
+                     (receiver.execution.completed_successfully(),
                       receiver.execution.timed_out))
         assert receiver.execution.completed_successfully()
 

router/smoke/openshift/test_openshift_templates.py

@@ -251,27 +251,25 @@ def validate_client_results(receiver, sender):
 
     # Debugging receiver results
     if not receiver.execution.completed_successfully():
-        logger.debug("Receiver did not complete successfully [exit code = %d]"
-                     % receiver.execution.returncode)
+        logger.debug("Receiver did not complete successfully")
         logger.debug("Receiver stdout = %s" % receiver.execution.read_stdout())
         logger.debug("Receiver stderr = %s" % receiver.execution.read_stderr())
 
     # Debugging sender results
     if not sender.execution.completed_successfully():
-        logger.debug("Sender did not complete successfully [exit code = %d]"
-                     % sender.execution.returncode)
+        logger.debug("Sender did not complete successfully")
         logger.debug("Sender stdout = %s" % sender.execution.read_stdout())
         logger.debug("Sender stderr = %s" % sender.execution.read_stderr())
 
     # Validating receiver results
     assert not receiver.execution.is_running()
-    assert receiver.execution.returncode == 0, \
+    assert receiver.execution.completed_successfully(), \
         '%s did not complete successfully' % receiver.implementation.upper()
 
     # Each message received will be printed as one line (plus some extra lines from Ansible)
     assert len(receiver.execution.read_stdout(lines=True)) >= MESSAGE_COUNT.get(receiver.implementation)
 
     # Validating if sender process completed without timing out
     assert not sender.execution.is_running()
-    assert sender.execution.returncode == 0, \
+    assert sender.execution.completed_successfully(), \
         '%s did not complete successfully' % sender.implementation.upper()

router/smoke/openshift_2/test_openshift_02_messaging.py

@@ -110,27 +110,25 @@ def validate_client_results(receiver: [ReceiverJava, ReceiverPython, ReceiverNod
 
     # Debugging receiver results
     if not receiver.execution.completed_successfully():
-        logger.debug("Receiver did not complete successfully [exit code = %d]"
-                     % receiver.execution.returncode)
+        logger.debug("Receiver did not complete successfully")
         logger.debug("Receiver stdout = %s" % receiver.execution.read_stdout())
         logger.debug("Receiver stderr = %s" % receiver.execution.read_stderr())
 
     # Debugging sender results
     if not sender.execution.completed_successfully():
-        logger.debug("Sender did not complete successfully [exit code = %d]"
-                     % sender.execution.returncode)
+        logger.debug("Sender did not complete successfully")
         logger.debug("Sender stdout = %s" % sender.execution.read_stdout())
         logger.debug("Sender stderr = %s" % sender.execution.read_stderr())
 
     # Validating receiver results
     assert not receiver.execution.is_running()
-    assert receiver.execution.returncode == 0, \
+    assert receiver.execution.completed_successfully(), \
         '%s did not complete successfully' % receiver.implementation.upper()
 
     # Each message received will be printed as one line (plus some extra lines from Ansible)
     assert len(receiver.execution.read_stdout(lines=True)) >= MESSAGE_COUNT
 
     # Validating if sender process completed without timing out
     assert not sender.execution.is_running()
-    assert sender.execution.returncode == 0, \
+    assert sender.execution.completed_successfully(), \
         '%s did not complete successfully' % sender.implementation.upper()