Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the new pokemon tutorial for 1.10 #5721

Open
wants to merge 6 commits into
base: upcoming
Choose a base branch
from

Conversation

hedara90
Copy link
Collaborator

Description

What it says on the tin.

Things to note in the release changelog:

  • Some changes compared to previous.

Discord contact info

hedara

@hedara90 hedara90 added the type: documentation Improvements or additions to documentation label Nov 26, 2024
Copy link
Collaborator

@Pawkkie Pawkkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos / updates to code involved in codeblocks, still reads great!

docs/tutorials/how_to_new_pokemon_1_10_0.md Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Outdated Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Outdated Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Outdated Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Show resolved Hide resolved
Copy link
Collaborator

@Pawkkie Pawkkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry clicked submit early

docs/tutorials/how_to_new_pokemon_1_10_0.md Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Outdated Show resolved Hide resolved
docs/tutorials/how_to_new_pokemon_1_10_0.md Outdated Show resolved Hide resolved
@Pawkkie Pawkkie self-assigned this Nov 27, 2024
@Pawkkie Pawkkie added this to the 1.10 milestone Nov 27, 2024
@hedara90
Copy link
Collaborator Author

Everything resolved, pending other opinions.

Pawkkie
Pawkkie previously approved these changes Nov 27, 2024
Copy link
Collaborator

@Pawkkie Pawkkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, if you want to wait for a greater consensus feel free!

@pkmnsnfrn
Copy link
Collaborator

I skimmed, lgtm, won't merge because I'd like one more pair of eyes who has actually added species in the past

@hedara90
Copy link
Collaborator Author

Is this where we call in someone unrelated that tries the instructions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants