New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 Class Conversion of ContextMenu extension #242

Open

daniel-lewis-ab wants to merge 1 commit into rgthree:main from daniel-lewis-ab:main

daniel-lewis-ab commented Jun 2, 2024 •

edited

Loading

This should enable your code to work with LiteGraph being converted over to ES6 classes.

It'd be awesome to test it out and pull it if it works so the transition doesn't cause any issues for ya.

As always, I suggest seeing the diff on VSCode b/c git can't handle indentation changes.


          ES6 Class Conversion of ContextMenu extension

369128d

daniel-lewis-ab closed this

daniel-lewis-ab reopened this

Contributor

DrJKL commented Jun 3, 2024

@daniel-lewis-ab I think you'll want to change the TS first

Author

daniel-lewis-ab commented Jun 3, 2024 via email

Thanks for the tip!

On Sun., Jun. 2, 2024, 18:00 Alexander Brown, ***@***.***> wrote: @daniel-lewis-ab <https://github.com/daniel-lewis-ab> I think you'll want to change the TS first <https://github.com/rgthree/rgthree-comfy/blob/main/src_web/comfyui/menu_auto_nest.ts> — Reply to this email directly, view it on GitHub <#242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC36LNZDH6ZQ3XUWWPPMPALZFOW3NAVCNFSM6AAAAABIVKISPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUGA3DOMRRGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Author

daniel-lewis-ab commented Jun 4, 2024

comfyanonymous/ComfyUI#3641

That's for the heads-up about why this PR is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet