This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Remove the storageDriver span from page, so that IE6/7 won't throw error... #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror, when someone tries to access getAttribute property on this span element.
For example, if you use attribute css selector on the page via YUI's Y.all(), e.g. Y.all('[data-attr]') in IE6/7, you would encounter this problem of seeing an JS error saying "Object does not support this property or method". That is because YUI's selector-css2's _filterNodes function tries to access getAttribute of the storageDriver element, which is a span element with added behavior: http://yuilibrary.com/yui/docs/api/files/dom_js_selector-css2.js.html#l161
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..., when someone tries to access getAttribute property on this span element.
For example, if you use attribute css selector on the page via YUI's Y.all(), e.g. Y.all('[data-attr]') in IE6/7, you would encounter this problem of seeing an JS error saying "Object does not support this property or method". That is because YUI's selector-css2's _filterNodes function tries to access getAttribute of the storageDriver element, which is a span element with added behavior: http://yuilibrary.com/yui/docs/api/files/dom_js_selector-css2.js.html#l161
@rgrove To reproduce the original problem, you can comment out the changes made in src/storage-lite.js, and run unit test. The newly added test "testIE67GetAttribute" would fail with the JS error mentioned above.