Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop observing #85

Merged
merged 2 commits into from
May 9, 2021
Merged

stop observing #85

merged 2 commits into from
May 9, 2021

Conversation

Cyber1000
Copy link
Contributor

this may solve #58

  • I say may, because on my AC2889 I didn't have the problem, maybe it depends on the device and software version how stable it is.
  • in this version I remove the observe immediately, but as said on my AC2889 the code works before and after the change without any problems

Maybe we should wait on user feedback in #58, on the other side it is safe to close the observe (tested many hours)

@Cyber1000 Cyber1000 mentioned this pull request Apr 25, 2021
Open
@Cyber1000 Cyber1000 mentioned this pull request May 8, 2021
Open
2 tasks
@rgerganov rgerganov merged commit cf53716 into rgerganov:master May 9, 2021
@Cyber1000 Cyber1000 deleted the observe branch May 9, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyber1000 @rgerganov