-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add select_ok
function to detect closed channels during select
#48
Open
kkroening
wants to merge
7
commits into
rgalanakis:master
Choose a base branch
from
kkroening:select-ok
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: #49 fixes CI for this branch |
I need a bit more time to review this... will get back to you soon. |
Cool, no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go, it's possible to detect closed channels inside a
select
. It doesn't appear that goless has any way to do this out-of-the-box, since theselect
function doesn't return anok
indication.Here's an example:
I added a
select_ok
function that behaves the same asselect
but handles closed channels correctly and returns anok
indication:Closed channels cases take precedence over the default case. And if a normal
select
is performed on a closed channel, aClosedChannel
exception is raised, similar to how Go complains in the same case.The changes to check for closed channels are a bit hacky: in
selecting.py
, it directly accesses the channels_closed
property. I'm not sure of a better way to do this. I tried changingrecv_ready
/send_ready
to returnTrue
if the channel is closed (which would cause theselect
to choose the corresponding case), but that broke a bunch of stuff. Would love to hear if there's a better way to do this.