Fixes

reyna-abhyankar · Aug 22, 2024 · 481c308 · 481c308
1 parent 02cc5bf
commit 481c308
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/lib/local-execution/include/local-execution/fwd_bwd_task_impl_function.h b/lib/local-execution/include/local-execution/fwd_bwd_task_impl_function.h
@@ -11,6 +11,7 @@ struct FwdBwdTaskImplFunction {
 
   bool operator==(FwdBwdTaskImplFunction const &) const;
   bool operator!=(FwdBwdTaskImplFunction const &) const;
+  bool operator<(FwdBwdTaskImplFunction const &) const;
 };
 
 std::string format_as(FwdBwdTaskImplFunction const &x);

diff --git a/lib/local-execution/src/fwd_bwd_task_impl_function.cc b/lib/local-execution/src/fwd_bwd_task_impl_function.cc
@@ -12,10 +12,15 @@ bool FwdBwdTaskImplFunction::operator!=(
   return this->function_ptr != other.function_ptr;
 }
 
+bool FwdBwdTaskImplFunction::operator<(
+    FwdBwdTaskImplFunction const &other) const {
+  return this->function_ptr < other.function_ptr;
+}
+
 std::string format_as(FwdBwdTaskImplFunction const &x) {
   std::ostringstream oss;
   oss << "<FwdBwdTaskImplFunction";
-  oss << " function_ptr=" << (void *)x.function_ptr;
+  oss << " function_ptr=" << reinterpret_cast<void *>(x.function_ptr);
   oss << ">";
   return oss.str();
 }

diff --git a/lib/local-execution/src/init_task_impl_function.cc b/lib/local-execution/src/init_task_impl_function.cc
@@ -13,7 +13,7 @@ bool InitTaskImplFunction::operator!=(InitTaskImplFunction const &other) const {
 std::string format_as(InitTaskImplFunction const &x) {
   std::ostringstream oss;
   oss << "<InitTaskImplFunction";
-  oss << " function_ptr=" << (void *)x.function_ptr;
+  oss << " function_ptr=" << reinterpret_cast<void *>(x.function_ptr);
   oss << ">";
   return oss.str();
 }

diff --git a/lib/local-execution/src/ops/input.cc b/lib/local-execution/src/ops/input.cc
@@ -1,6 +1,4 @@
 #include "input.h"
-#include "local-execution/op_task_invocation.h"
-#include "utils/hash-utils.h"
 
 namespace FlexFlow {
 

diff --git a/lib/local-execution/src/ops/noop.cc b/lib/local-execution/src/ops/noop.cc
@@ -14,7 +14,6 @@
  */
 
 #include "noop.h"
-#include "utils/hash-utils.h"
 
 namespace FlexFlow {
 

diff --git a/lib/local-execution/src/ops/weight.cc b/lib/local-execution/src/ops/weight.cc
@@ -1,6 +1,4 @@
 #include "weight.h"
-#include "local-execution/op_task_invocation.h"
-#include "utils/hash-utils.h"
 
 namespace FlexFlow {
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,7 +14,6 @@ @@
      */
     #include "noop.h"
-    #include "utils/hash-utils.h"
     namespace FlexFlow {
@@ Expand Down @@