-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wheels release #68
Conversation
Seems like `cibuildwheel` requires `--only` to be non-empty.
@doublethefish this builds all the wheels successfully on my fork :) would appreciate if you could take a look! |
Oh awesome! And it only took 32mins to complete on your fork; did you do anything specific to make it take less than the 5 hours I was seeing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is always better to put more information that "Appease clang" for changes like this.
In future I would like to see the specific "appeasement" that is occurring but in this case I assume it is a warning about template ambiguity.
moved to commit.
Thanks @doublethefish ! Sorry, I wasn't very diligent with the commit messages and history, I was expecting that you'd squash the whole PR 😌 Regarding
which is a relatively recent addition to clang: llvm/llvm-project#80801 Regarding 32 mins: that number is end-to-end but depends on available parallelism (in GitHub free tier?) at the moment. Each job takes about 5 mins (10 mins for macos x86_64) so best case you'd see 10 mins end-to-end, worst case ~2 hours (if everything is sequential). Thanks again! I believe some of the long-standing issues can be closed now :) |
No worries, thanks for the PR. We are very grateful.
Thanks for that it's useful to the specific warning, and edifying to know that I guessed right about the type of warning it was 🤓. As you probably know, |
Sounds great @doublethefish ! Would you be willing to release the wheels to PyPI? |
Yes, of course. But it will have to be sometime over the next few days. |
Use latest
cibuildwheel
and fix all errors.