Skip to content

Commit

Permalink
chore(actions): allow --arch in github action to work
Browse files Browse the repository at this point in the history
We do this by removing the arch-flag overrides in pyproject.toml which
seems to be respected ahead of the --arch flag on the command-line.

When running this from a developer machine we should end up building
whatever that developer machine can build, one/none/all archs.
  • Loading branch information
doublethefish committed Nov 28, 2024
1 parent 2abec7d commit 4fd7b9a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@ before-build = """\
LIBOGDF_INSTALL_PATH="$(pwd)/libOGDF"

[tool.cibuildwheel.macos]
# For now build `x86_64` and `arm64` instead of `universal2` because we currently do
# not build /usr/local/lib/libOGDF.dylib under `arm64` for some reason.
archs = ["x86_64", "arm64"]
# Specify the --arch flag in the github-action, achieving the following:
# - we fall-back to default arch local-dev machines.
# - we build the best arch on the best platform for that arch in github
# actions.
# archs = ["x86_64", "arm64"]
before-all = ["brew install libomp llvm"]
# NOTE: we delete build/ here as we're build multiple wheels and we support
# different SIMD commands on different platforms.
Expand Down

0 comments on commit 4fd7b9a

Please sign in to comment.