Fix svg drawer #189
Open
Fix svg drawer #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.draw()` Resolves reymond-group#171. Although the `weights` parameter was added to `SvgDrawer.draw()` in f3693b3, the method call in `Drawer.draw()` wasn't updated correspondingly. `Drawer.draw()` could be amended to also take a `weights` argument, which it would pass to `SvgDrawer.draw()`, but this might break existing code even more and would require an update of the documentation of the README.
✅ Deploy Preview for smilesdrawer-doc canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SVG drawer,
weightscan befalse, in which case running.everyon them is invalid. This adds a guard.Note this incorporates changes from #175 too, as these two changes are the bare minimum for SVG rendering to work.