action: migrate from go/v3 to go/v4

Signed-off-by: Rewant Soni <[email protected]>

.gitignore

@@ -90,4 +90,7 @@ tags
 
 # Support for Project snippet scope
 
+# Created by Mac
+*.DS_Store
+
 # End of https://www.toptal.com/developers/gitignore/api/go,vim,visualstudiocode,git

Dockerfile

@@ -10,10 +10,11 @@ COPY go.mod go.sum ./
 COPY vendor/ vendor/
 
 # Copy the project source
-COPY main.go Makefile ./
+COPY Makefile ./
+COPY cmd/main.go cmd/main.go
 COPY hack/ hack/
 COPY api/ api/
-COPY controllers/ controllers/
+COPY internal/controller/ internal/controller/
 COPY config/ config/
 COPY pkg/ pkg/
 COPY service/ service/

Makefile

@@ -79,7 +79,7 @@ go-build: ## Run go build against code.
 	@GOBIN=${GOBIN} ./hack/go-build.sh
 
 run: manifests generate fmt vet ## Run a controller from your host.
-	go run ./main.go
+	go run ./cmd/main.go
 
 container-build: test ## Build container image with the manager.
 	$(IMAGE_BUILD_CMD) build --platform="linux/amd64" -t ${IMG} .

PROJECT

@@ -4,7 +4,7 @@
 # More info: https://book.kubebuilder.io/reference/project-config.html
 domain: openshift.io
 layout:
-- go.kubebuilder.io/v3
+- go.kubebuilder.io/v4
 plugins:
   manifests.sdk.operatorframework.io/v2: {}
   scorecard.sdk.operatorframework.io/v2: {}

main.go → cmd/main.go

@@ -21,7 +21,7 @@ import (
 	"os"
 
 	apiv1alpha1 "github.com/red-hat-storage/ocs-client-operator/api/v1alpha1"
-	"github.com/red-hat-storage/ocs-client-operator/controllers"
+	"github.com/red-hat-storage/ocs-client-operator/internal/controller"
 	"github.com/red-hat-storage/ocs-client-operator/pkg/templates"
 	"github.com/red-hat-storage/ocs-client-operator/pkg/utils"
 	admwebhook "github.com/red-hat-storage/ocs-client-operator/pkg/webhook"
@@ -155,7 +155,7 @@ func main() {
 		}},
 	)
 
-	if err = (&controllers.StorageClientReconciler{
+	if err = (&controller.StorageClientReconciler{
 		Client:            mgr.GetClient(),
 		Scheme:            mgr.GetScheme(),
 		OperatorNamespace: utils.GetOperatorNamespace(),
@@ -164,7 +164,7 @@ func main() {
 		os.Exit(1)
 	}
 
-	if err = (&controllers.StorageClaimReconciler{
+	if err = (&controller.StorageClaimReconciler{
 		Client:            mgr.GetClient(),
 		Scheme:            mgr.GetScheme(),
 		OperatorNamespace: utils.GetOperatorNamespace(),
@@ -182,7 +182,7 @@ func main() {
 		os.Exit(1)
 	}
 
-	if err = (&controllers.OperatorConfigMapReconciler{
+	if err = (&controller.OperatorConfigMapReconciler{
 		Client:            mgr.GetClient(),
 		Scheme:            mgr.GetScheme(),
 		OperatorNamespace: utils.GetOperatorNamespace(),

hack/go-build.sh

@@ -7,5 +7,5 @@ export GO111MODULE=${GO111MODULE:-on}
 
 set -x
 
-go build -a -o ${GOBIN:-bin}/manager main.go
+go build -a -o ${GOBIN:-bin}/manager cmd/main.go
 go build -a -o ${GOBIN:-bin}/status-reporter ./service/status-report/main.go

controllers/generate.go → internal/controller/generate.go

@@ -14,4 +14,4 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller

controllers/operatorconfigmap_controller.go → internal/controller/operatorconfigmap_controller.go

@@ -11,7 +11,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 import (
 	"bytes"

controllers/sliceutils.go → internal/controller/sliceutils.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 //nolint:deadcode,unused
 func contains(slice []string, s string) bool {

controllers/sliceutils_test.go → internal/controller/sliceutils_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 import (
 	"testing"

controllers/storageclaim_controller.go → internal/controller/storageclaim_controller.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 import (
 	"context"

controllers/storageclient_controller.go → internal/controller/storageclient_controller.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 import (
 	"context"

controllers/suite_test.go → internal/controller/suite_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package controllers
+package controller
 
 import (
 	"path/filepath"
@@ -49,7 +49,7 @@ var _ = BeforeSuite(func() {
 
 	By("bootstrapping test environment")
 	testEnv = &envtest.Environment{
-		CRDDirectoryPaths:     []string{filepath.Join("..", "config", "crd", "bases")},
+		CRDDirectoryPaths:     []string{filepath.Join("..", "..", "config", "crd", "bases")},
 		ErrorIfCRDPathMissing: false,
 	}