Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide siginfo to signal callback if possible #79

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Provide siginfo to signal callback if possible #79

wants to merge 8 commits into from

Conversation

danog
Copy link
Contributor

@danog danog commented Jun 14, 2023

No description provided.

@bwoebi
Copy link
Contributor

bwoebi commented Jul 23, 2023

You still could add it to the EventLoop class, but behind a method_exists call.

@danog
Copy link
Contributor Author

danog commented Jul 24, 2023

You still could add it to the EventLoop class, but behind a method_exists call.

mm @trowski and @kelunik is this OK?

@kelunik
Copy link
Member

kelunik commented Jul 24, 2023

No, we want to keep that strictly to the stream select driver for now.

@danog
Copy link
Contributor Author

danog commented Jul 24, 2023

OK, should be good to merge mostly, can't reproduce that phpunit failure on 8.2 though, and it doesn't seem related to my change...

@trowski
Copy link
Member

trowski commented Aug 7, 2023

SignalCallbackExtra is a pretty terrible name (even though it is internal). How about SignalCallbackWithInfo? @kelunik, thoughts?

@kelunik
Copy link
Member

kelunik commented Aug 7, 2023

I want to provide a different patch, just need to find time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danog @bwoebi @kelunik @trowski