Avoid env.temp_data.update()

[AA-Turner]

Hello,

In Sphinx, we are looking to change temp_data from a dict to a better-typed object (c.f. sphinx-doc/sphinx#13151). This change will be backward compatible, but this repo is one of only two instances I have found of temp_data.update(), and currently temp_data is not really public API de jure. This PR ought to maintain the current behaviour, and will be forward-compatible should we look to deprecate .update() in the future.

A

[chipx86]

I appreciate the fix! Thanks for sending that our way. We'll get it merged.

[chipx86]

We really should avoid touching the internals too much. I'll have to see if there's a better way of doing what we're trying to do at some point. I think we also reach into some internals over at https://github.com/beanbaginc/beanbag-docutils, but we do so fully understanding the Sphinx project owes us nothing and that any new release may break us.

Thanks for all the work on Sphinx, by the way. It's one of my favorite tools in the Python ecosystem.