feat: make websocket an optional peer dependency #291
+80
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hainesy
approved these changes
Dec 2, 2024
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
websocketdependency a peer dependency.The motivation for this change
websocketdependency is not used in all cases, only with the streaming clientwebsocketdependency is arguably worse thanwsandwebsocketpulls in a lot of native dependencies. It's a common practice that any dependency that pulls inwebsockethas it as an optional peer dependency for that given reason.Additionally, this PR adds an
enginesdefinition and apackageManagerfield to make the expected tools easier to discover.