Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ci #26

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Fixed ci #26

merged 3 commits into from
Dec 16, 2024

Conversation

ilia-rassadin-rn
Copy link

@ilia-rassadin-rn ilia-rassadin-rn commented Dec 16, 2024 •
edited
Loading

I've renovated .github workflow a bit and fixed broken tests.

  1. I've added golangci-lint instead of golint and custom script
  2. I've updated go versions used to run tests
  3. I've fixed the tests since some of them were actually broken. I have no idea how it worked before.

@ilia-rassadin-rn ilia-rassadin-rn force-pushed the ir-rn-fix-ci branch 12 times, most recently from 7f87db1 to 3b93950 Compare December 16, 2024 15:27
@ilia-rassadin-rn ilia-rassadin-rn marked this pull request as ready for review December 16, 2024 15:33
@ilia-rassadin-rn ilia-rassadin-rn merged commit 47a71c7 into master Dec 16, 2024
4 checks passed
@ilia-rassadin-rn ilia-rassadin-rn deleted the ir-rn-fix-ci branch December 16, 2024 15:42
@ilia-rassadin-rn
Copy link
Author

I've figured out how it worked before, but it seems that it was a bug to not check the error in a few places that was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azhiv azhiv azhiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilia-rassadin-rn @azhiv