Fix #226 (and fix some consistency issues)

[aldahick]

As noted in #226, this increases the number of API calls per resume quite a bit, and that may be unacceptable. Regardless, I've fixed #226 because the call increase may not be unacceptable.

Also there were some things that I fixed in 3e5ccaf.

[raphink]

This fixes contribution count properly, but it doesn't sort contributions by count.

[serejahh]

Hi @aldahick. Could you sort the repos in correct order. So it's gonna be merged. Thanks in advance

[aldahick]

@serejahh I'm not sure what you mean by sorting the repositories. Could you explain?

[serejahh]

@aldahick The repos should be sorted by count of commits - the more commits, the higher in the list. I've deployed your version and what I see:

As you can see the repos aren't sorted by commits

[jonschlinkert]

the repos should be sorted by count of commits

Honestly, IMHO that seems a strange thing to sort by. I think most people would expect to see the libraries either sorted alphabetically for easier discovery, or by something that matters more than commits, like stars, or when available, downloads.

[serejahh]

@jonschlinkert
The reason why I think so - it's my resume and it supposed to be sent to a HR manager, for example, so I would like to mention top-10 repos I support, not just any 10 libs. I'd be better to have kind of sort by option

[daurnimator]

Honestly, IMHO that seems a strange thing to sort by. I think most people would expect to see the libraries either sorted alphabetically for easier discovery, or by something that matters more than commits, like stars, or when available, downloads.

I disagree: number of commits is probably the best approximation to how much work you've put into the project (vs popularity of the project)

[Tais993]

I disagree: number of commits is probably the best approximation to how much work you've put into the project (vs popularity of the project)

Lets say you make 30 commits to your own project, which isn't fancy.
Now compare this to 1 commit to Linux (which is a lot more worth than your average commit)

It depends too much, the idea of a "sort by" option as @serejahh descriped would IMO be the best solution.
Currently commit count is useless, and merging this PR is really important I'd say, I'd rather see sort on commit count.
A "sort by" option can be added in another PR, if someone is interested in implementing.

[daurnimator]

Now compare this to 1 commit to Linux (which is a lot more worth than your average commit)

It might be worth a little more; maybe double. But otherwise no.

[jonschlinkert]

It might be worth a little more; maybe double. But otherwise no.

Commits, by themselves, are not an interesting metric. Most maintainers prefer squashing commits, and lots of consecutive commits with various changes versus one big commit is arbitrary to anyone who might be looking for people to hire.

You could make 1,000 commits to a project no one uses, and it won't get anyone's attention. Or you can make one great commit to a popular project and it will get lots of attention.

Consider that I have nothing to gain or lose by sharing this information. I'm not trying to debate you for any particular reason. I'm trying to help you. I'm not claiming to be the expert in all things, I've had lots of success in my own projects on GitHub and I just wanted to pay it forward and try to share some tips that have worked well for me.

[daurnimator]

Commits, by themselves, are not an interesting metric. Most maintainers prefer squashing commits, and lots of consecutive commits with various changes versus one big commit is arbitrary to anyone who might be looking for people to hire.

At least with the projects I've worked with, squashing commits is very rare.