Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global and Per-client properties to disable default ResponseExceptionMappe #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chonton
Copy link
Contributor

@chonton chonton commented Nov 28, 2024

Global and Per-client properties to disable default ResponseExceptionMapper
and properties to disable invoking ResponseExceptionMapper when method return type is jakarta.ws.rs.core.Response

documentation will need to be updated downstream:

New property effective in both programatic client api and global config:
microprofile.rest.client.disable.response.exceptions - disables invoking client exception mapper when the proxy method return type is akarta.ws.rs.core.Response

New annotation keyed properties:
{fqcn | key}/mp-rest/disableResponseExceptions - per client microprofile.rest.client.disable.response.exceptions configuration
{fqcn | key}/mp-rest/disableDefaultMapper - per client microprofile.rest.client.disable.default.mapper configuration

Closes #23957, #44813

…Mapper

and properties to disable invoking ResponseExceptionMapper when method return type is jakarta.ws.rs.core.Response
@jamezp
Copy link
Contributor

jamezp commented Dec 19, 2024

Part of this seems like it should be a feature request for the spec itself. IMO we can't use microprofile.rest.client.disable.response.exceptions as the property name as that is reserved for the specification.

If the microprofile.rest.client.disable.default.mapper doesn't work per-client, that does seem like a bug as the specification seems to required it https://download.eclipse.org/microprofile/microprofile-rest-client-4.0/microprofile-rest-client-spec-4.0.html#_default_responseexceptionmapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants