Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert laminas-code to upstream #30

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Revert laminas-code to upstream #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c49f69
Revert laminas-code to upstream
mdio Jan 8, 2024
ee7df4e
Remove PHP 8.3 as it doesn't work, yet
mdio Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
tests:
strategy:
matrix:
php-versions: ['8.0', '8.1', '8.2']
php-versions: ['8.1', '8.2']
dependency-versions: ['lowest', 'highest']

runs-on: ubuntu-latest
Expand Down
9 changes: 2 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ the use of reflection on production.

# Prerequisites

This library needs PHP 8.0+.
This library needs PHP 8.1+.

It has been tested using PHP 8.0 - PHP 8.1 - PHP 8.2.
It has been tested using PHP 8.1 and PHP 8.2.


# Installation
Expand Down Expand Up @@ -143,12 +143,7 @@ class GenerateDependencyInjectionFactories extends \Symfony\Component\Console\Co
require_once $fullpath;

$astLocator = (new \Roave\BetterReflection\BetterReflection())->astLocator();

// for roave/better-reflection 4.x (PHP 7.4)
$reflector = new \Roave\BetterReflection\Reflector\ClassReflector(new Roave\BetterReflection\SourceLocator\Type\SingleFileSourceLocator($fileName, $astLocator));
$classes = $reflector->getAllClasses();

// for roave/better-reflection 5.x (PHP 8.0)
$reflector = new \Roave\BetterReflection\Reflector\DefaultReflector(new Roave\BetterReflection\SourceLocator\Type\SingleFileSourceLocator($fileName, $astLocator));
$classes = $reflector->reflectAllClasses();

Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
}
],
"require": {
"php": ">=8.0",
"php": ">=8.1",
"doctrine/annotations": "^1.12|^2.0.0",
"rg/laminas-code": "4.7.4",
"laminas/laminas-code": "^4.13",
"psr/log": "^1.0.0"
},
"require-dev": {
Expand Down